[9.0.0] Make --incompatible_enable_proto_toolchain_resolution default to true in Bazel #28182
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in Bazel. This change updates the default value of the --incompatible_enable_proto_toolchain_resolution flag to true for Bazel builds. The flag's default value and name are now defined in FlagConstants, with different values for the open-source and internal versions. PiperOrigin-RevId: 844684939 Change-Id: I264db1921e52e885d1e211f2a627d42ce380bd41
github-actions
bot
added
team-Rules-Java
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default value of the --incompatible_enable_proto_toolchain_resolution flag to true. The change is implemented by centralizing the flag's default value and name in FlagConstants, which is a good practice for managing flags that may have different defaults in different environments. The related test StarlarkJavaLiteProtoLibraryTest is correctly updated to explicitly set the old flag value to maintain its behavior. The changes are clean, correct, and follow existing patterns in the codebase. I have no further comments.
iancha1992
approved these changes
Jan 8, 2026
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the default value of the --incompatible_enable_proto_toolchain_resolution flag to true for Bazel builds.
This is essentially an internal flag flip, coordinated with the protobuf upgrade in Bazel 9. Users are not expected to have to perform any migration.